summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFiodor Suietov <fiodor.f.suietov@intel.com>2006-12-19 12:33:20 -0800
committerJeff Garzik <jeff@garzik.org>2007-02-16 13:32:41 -0500
commit9de1cc9c446d39546a3d9dd6f7d99a980a7ecc22 (patch)
tree04ef6996082fe234643f483c61d552b5fc56d159
parent08573a86c8da1379b4f341ab4781bb7c8685d5b6 (diff)
[PATCH] libata: wrong sizeof for BUFFER
I have reproduced the AE_AML_BUFFER_LIMIT exception mentioned in <http://bugzilla.kernel.org/show_bug.cgi?id=7689> basing on the SSDT ASL code and libata ata_acpi_push_id() code. There is an oversight in ata_acpi_push_id() causing the exception. The following update fixes it: Signed-off-by: Fiodor Suietov <fiodor.f.suietov@intel.com> Cc: Jeff Garzik <jeff@garzik.org> Cc: Tejun Heo <htejun@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r--drivers/ata/libata-acpi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index f2fd0dda70f..b4e8be5d292 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -672,7 +672,7 @@ int ata_acpi_push_id(struct ata_port *ap, unsigned int ix)
input.count = 1;
input.pointer = in_params;
in_params[0].type = ACPI_TYPE_BUFFER;
- in_params[0].buffer.length = sizeof(atadev->id[0] * ATA_ID_WORDS);
+ in_params[0].buffer.length = sizeof(atadev->id[0]) * ATA_ID_WORDS;
in_params[0].buffer.pointer = (u8 *)atadev->id;
/* Output buffer: _SDD has no output */