summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRomain Kuntz <r.kuntz@ipflavors.com>2013-01-09 15:02:26 +0100
committerDavid S. Miller <davem@davemloft.net>2013-01-10 14:13:33 -0800
commit85da53bf1c336bb07ac038fb951403ab0478d2c5 (patch)
treebf00e0267e05f2c6a8df00201d6aea4e25d394fc
parentf26845b43c75d3f32f98d194c1327b5b1e6b3fb0 (diff)
ipv6: fix the noflags test in addrconf_get_prefix_route
The tests on the flags in addrconf_get_prefix_route() does no make much sense: the 'noflags' parameter contains the set of flags that must not match with the route flags, so the test must be done against 'noflags', and not against 'flags'. Signed-off-by: Romain Kuntz <r.kuntz@ipflavors.com> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/addrconf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 408cac4ae00..29ba4ff186e 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1877,7 +1877,7 @@ static struct rt6_info *addrconf_get_prefix_route(const struct in6_addr *pfx,
continue;
if ((rt->rt6i_flags & flags) != flags)
continue;
- if ((noflags != 0) && ((rt->rt6i_flags & flags) != 0))
+ if ((rt->rt6i_flags & noflags) != 0)
continue;
dst_hold(&rt->dst);
break;