diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-10 12:52:02 +0800 |
|---|---|---|
| committer | Ohad Ben-Cohen <ohad@wizery.com> | 2012-09-10 13:19:25 +0300 |
| commit | e352614cd3e7a5f7af7cff894a3b5a705181de21 (patch) | |
| tree | 5f2ddc609cdd1e54c59f638af6a3f890aa81da0d | |
| parent | 55d512e245bc7699a8800e23df1a24195dd08217 (diff) | |
hwspinlock/core: move the dereference below the NULL test
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
| -rw-r--r-- | drivers/hwspinlock/hwspinlock_core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c index 1201a15784c..db713c0dfba 100644 --- a/drivers/hwspinlock/hwspinlock_core.c +++ b/drivers/hwspinlock/hwspinlock_core.c @@ -552,7 +552,7 @@ EXPORT_SYMBOL_GPL(hwspin_lock_request_specific); */ int hwspin_lock_free(struct hwspinlock *hwlock) { - struct device *dev = hwlock->bank->dev; + struct device *dev; struct hwspinlock *tmp; int ret; @@ -561,6 +561,7 @@ int hwspin_lock_free(struct hwspinlock *hwlock) return -EINVAL; } + dev = hwlock->bank->dev; mutex_lock(&hwspinlock_tree_lock); /* make sure the hwspinlock is used */ |