diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-11-17 18:08:57 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2012-11-18 10:24:49 +0100 |
| commit | 379170a42c84cee5f95fac536a4b5b76843baf90 (patch) | |
| tree | 711883cc5769c9d9cfccfcf211bc6a9b29d1de41 | |
| parent | 190006f9d6594ee9ef4775ec09edda7df76fc8f1 (diff) | |
sound: oss/sb_audio: cap value in sb201_audio_set_speed()
We set "s" before we have capped "speed" so it could be the wrong value.
This could lead to a divide by zero bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/oss/sb_audio.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/oss/sb_audio.c b/sound/oss/sb_audio.c index b2b3c014221..048439a1600 100644 --- a/sound/oss/sb_audio.c +++ b/sound/oss/sb_audio.c @@ -442,7 +442,7 @@ static int sb201_audio_set_speed(int dev, int speed) { sb_devc *devc = audio_devs[dev]->devc; int tmp; - int s = speed * devc->channels; + int s; if (speed > 0) { @@ -452,6 +452,7 @@ static int sb201_audio_set_speed(int dev, int speed) speed = 44100; if (devc->opened & OPEN_READ && speed > 15000) speed = 15000; + s = speed * devc->channels; devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff; tmp = 256 - devc->tconst; speed = ((1000000 + tmp / 2) / tmp) / devc->channels; |