diff options
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2013-12-09 15:30:50 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-17 10:01:50 -0800 |
| commit | 5d4997bbfa3bb7ed4786bd96bfcc756b02f9551a (patch) | |
| tree | d3507b827d4438a4105ec8e73b8716c9ab3f1a8d | |
| parent | 7af64f9acb2b13f24dfbb1c0aac91229671314d6 (diff) | |
staging: comedi: pcmmio: tidy up the ao subdevice init
Add some whitespace to the analog output subdevice init and reorder the
init to follow the "norm" in comedi drivers.
Remove the init of len_chanlist. This member is only used for subdevices
the support async commands. The core will default the value correctly.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/comedi/drivers/pcmmio.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c index 9338f0c95f9..39dff77c365 100644 --- a/drivers/staging/comedi/drivers/pcmmio.c +++ b/drivers/staging/comedi/drivers/pcmmio.c @@ -1016,16 +1016,15 @@ static int pcmmio_attach(struct comedi_device *dev, struct comedi_devconfig *it) outb(0, dev->iobase + PCMMIO_AI_2ND_ADC_OFFSET + PCMMIO_AI_RESOURCE_REG); - /* Next, AO */ + /* Analog Output subdevice */ s = &dev->subdevices[1]; - s->maxdata = 0xffff; - s->range_table = &pcmmio_ao_ranges; - s->subdev_flags = SDF_READABLE; - s->type = COMEDI_SUBD_AO; - s->n_chan = 8; - s->len_chanlist = s->n_chan; - s->insn_read = pcmmio_ao_insn_read; - s->insn_write = pcmmio_ao_insn_write; + s->type = COMEDI_SUBD_AO; + s->subdev_flags = SDF_READABLE; + s->n_chan = 8; + s->maxdata = 0xffff; + s->range_table = &pcmmio_ao_ranges; + s->insn_read = pcmmio_ao_insn_read; + s->insn_write = pcmmio_ao_insn_write; /* initialize the resource enable register by clearing it */ outb(0, dev->iobase + PCMMIO_AO_RESOURCE_ENA_REG); |