summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Uhlenkott <juhlenko@akamai.com>2008-02-07 00:15:05 -0800
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2008-02-07 08:42:23 -0800
commit870897a5ab60a6afeba0a7eff42d21faf79edf33 (patch)
treed92a322c18f7e20bf0641151e05596aa46b25719
parent7ed31e0fa0e595a8840dbb6c60a7207b5bd90333 (diff)
drivers/edac/i3000: document type promotion
By popular request, add a comment documenting the implicit type promotion here. Signed-off-by: Jason Uhlenkott <juhlenko@akamai.com> Signed-off-by: Doug Thompson <dougthompson@xmission.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/edac/i3000_edac.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/edac/i3000_edac.c b/drivers/edac/i3000_edac.c
index b813f356b39..5d4292811c1 100644
--- a/drivers/edac/i3000_edac.c
+++ b/drivers/edac/i3000_edac.c
@@ -44,6 +44,13 @@
*/
#define I3000_DEAP_GRAIN (1 << 7)
+/*
+ * Helper functions to decode the DEAP/EDEAP hardware registers.
+ *
+ * The type promotion here is deliberate; we're deriving an
+ * unsigned long pfn and offset from hardware regs which are u8/u32.
+ */
+
static inline unsigned long deap_pfn(u8 edeap, u32 deap)
{
deap >>= PAGE_SHIFT;