diff options
| author | Christian Engelmayer <cengelma@gmx.at> | 2014-04-28 11:34:32 +0930 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2014-04-28 11:48:34 +0930 |
| commit | 2ee41e62ba5b952e9d9fcba6f7079a0c608bb849 (patch) | |
| tree | f04675dda077b17953fd1360763f0f8b8fd74b8f | |
| parent | ec6931b281797b69e6cf109f9cc94d5a2bf994e0 (diff) | |
modpost: Fix resource leak in read_dump()
Function read_dump() memory maps the input via grab_file(), but fails to call
the corresponding unmap function. Add the missing call to release_file().
Detected by Coverity: CID 1192419
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
| -rw-r--r-- | scripts/mod/modpost.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 06635567393..ea3e2bdf182 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2113,8 +2113,10 @@ static void read_dump(const char *fname, unsigned int kernel) s->preloaded = 1; sym_update_crc(symname, mod, crc, export_no(export)); } + release_file(file, size); return; fail: + release_file(file, size); fatal("parse error in symbol dump file\n"); } |