summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-04-05 22:28:14 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2006-04-09 22:25:29 -0700
commitcdee5751bf91d02616aaf30a5affef56105e3b79 (patch)
tree8a7d6f231dc9de03c7d9bb5b6623bd539900abce
parentad96b485b4224785bcca478cfba02d06c46ee575 (diff)
[BLUETOOTH] sco: Possible double free.
this fixes coverity bug id #1068. hci_send_sco() frees skb if (skb->len > hdev->sco_mtu). Since it returns a negative error value only in this case, we can directly return here. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/bluetooth/sco.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index 6b61323ce23..0c2d13ad69b 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -255,7 +255,7 @@ static inline int sco_send_frame(struct sock *sk, struct msghdr *msg, int len)
}
if ((err = hci_send_sco(conn->hcon, skb)) < 0)
- goto fail;
+ return err;
return count;