summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Jones <davej@redhat.com>2005-10-27 16:02:06 -0700
committerDave Jones <davej@redhat.com>2005-10-27 16:02:06 -0700
commitbc7b26fd7ca5e0c6e769d3886c022f0a98fd88ec (patch)
tree19f23041be60367024f292780ba3e79ff3259fc8
parente98df50c5200ae3c748d69002a8827afc9d2eae2 (diff)
[CPUFREQ] Check return value of cpufreq_cpu_get in cpufreq_stats
This fixes an issue found in drivers/cpufreq/cpufreq_stats.c by Coverity. Error reported: CID: 2642 Checker: NULL_RETURNS (help) File: /export2/p4-coverity/mc2/linux26/drivers/cpufreq/cpufreq_stats.c Function: cpufreq_stats_create_table Description: Dereferencing NULL value "data" Patch description: The return of cpufreq_cpu_get can be NULL, check return code and return -EINVAL if it is NULL. Signed-off-by: Jayachandran C. <c.jayachandran at gmail.com> Signed-off-by: Dave Jones <davej@redhat.com>
-rw-r--r--drivers/cpufreq/cpufreq_stats.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
index ff16a87125d..19b4c3e7c39 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -196,6 +196,11 @@ cpufreq_stats_create_table (struct cpufreq_policy *policy,
return -ENOMEM;
data = cpufreq_cpu_get(cpu);
+ if (data == NULL) {
+ ret = -EINVAL;
+ goto error_get_fail;
+ }
+
if ((ret = sysfs_create_group(&data->kobj, &stats_attr_group)))
goto error_out;