diff options
| author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2010-09-09 11:47:49 +0900 |
|---|---|---|
| committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2010-09-10 16:07:40 +0100 |
| commit | f4363b7d88e99497e4241397efee09b106d802c4 (patch) | |
| tree | 668a3b3cebc4b4efe9e6b89a28993d1ee2acfe13 | |
| parent | 5fbdedf072500859601705fa6f07a9e895d5e3a8 (diff) | |
fbdev: sh_mobile_hdmi: modify noisy comment out
This patch solve below report from Guennadi
1)
> - hdmi_write(hdmi, 0x00, HDMI_AUDIO_SETTING_1);
> + switch (pdata->flags & HDMI_SRC_MASK) {
> + default:
> + /* FALL THROUGH */
I'm not sure I like the capitalisation here - no reason to shout;)
2)
> +/************************************************************************
> +
> +
> + HDMI sound
> +
> +
> +************************************************************************/
I don't think this comment deserves 7 lines of text, besides breaking the
multiline comment style. If you think, one line like
/* HDMI sound */
is not enough how about just
/*
* HDMI sound
*/
3)
> +/************************************************************************
> +
> +
> + HDMI video
> +
> +
> +************************************************************************/
See above - 7 lines seem to be an overkill to me.
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
| -rw-r--r-- | drivers/video/sh_mobile_hdmi.c | 21 |
1 files changed, 7 insertions, 14 deletions
diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c index 16187d66255..0acd850f73b 100644 --- a/drivers/video/sh_mobile_hdmi.c +++ b/drivers/video/sh_mobile_hdmi.c @@ -224,13 +224,9 @@ static u8 hdmi_read(struct sh_hdmi *hdmi, u8 reg) return ioread8(hdmi->base + reg); } -/************************************************************************ - - - HDMI sound - - -************************************************************************/ +/* + * HDMI sound + */ static unsigned int sh_hdmi_snd_read(struct snd_soc_codec *codec, unsigned int reg) { @@ -273,13 +269,10 @@ static struct snd_soc_codec_driver soc_codec_dev_sh_hdmi = { .write = sh_hdmi_snd_write, }; -/************************************************************************ - - - HDMI video - +/* + * HDMI video + */ -************************************************************************/ /* External video parameter settings */ static void hdmi_external_video_param(struct sh_hdmi *hdmi) { @@ -398,7 +391,7 @@ static void sh_hdmi_audio_config(struct sh_hdmi *hdmi) */ switch (pdata->flags & HDMI_SRC_MASK) { default: - /* FALL THROUGH */ + /* fall through */ case HDMI_SRC_I2S: data = (0x0 << 3); break; |