diff options
| author | Andrey Ryabinin <a.ryabinin@samsung.com> | 2015-01-26 19:48:16 +0300 |
|---|---|---|
| committer | Dominique Martinet <dominique.martinet@cea.fr> | 2015-03-13 18:08:12 +0100 |
| commit | 70291e738dce8c1ca713c25030db240c9b09a262 (patch) | |
| tree | 72548934adb9f91a2579e1ae2114ccc45b7ecdb7 | |
| parent | 94f8dfb6ca3e95603cc641b2a0d356f611fdb5ad (diff) | |
net/9p: fix format string in p9_mount_tag_show()
Using "%s" for non-NULL terminated string is quite
dangerous, since this causes reading out of bounds.
chan->tag is non-NULL terminated, so precision
must be specified for printing it.
Fixes: 86c8437383ac ("net/9p: Add sysfs mount_tag file for virtio 9P device")
Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
| -rw-r--r-- | net/9p/trans_virtio.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index d8e376a5f0f..b689a7f0179 100644 --- a/net/9p/trans_virtio.c +++ b/net/9p/trans_virtio.c @@ -504,7 +504,8 @@ static ssize_t p9_mount_tag_show(struct device *dev, vdev = dev_to_virtio(dev); chan = vdev->priv; - return snprintf(buf, chan->tag_len + 1, "%s", chan->tag); + return snprintf(buf, chan->tag_len + 1, "%.*s", + chan->tag_len, chan->tag); } static DEVICE_ATTR(mount_tag, 0444, p9_mount_tag_show, NULL); |