diff options
author | Nicu Ioan Petru <ionut.nicu@freescale.com> | 2007-04-13 01:26:29 -0500 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-04-28 11:01:05 -0400 |
commit | 3a8205ead4dc4b05fbc164eeb852b8f8921d11d3 (patch) | |
tree | d78277465c1a5bfc31f2855145da5715ed2648f3 /COPYING | |
parent | d5b9049df25f38b3eaf3af48d494b0747aae4349 (diff) |
ucc_geth: fixes for ucc_geth_memclean
The ucc_geth_memclean function can be called before the Tx BD rings, Rx
BD rings and associated socket buffers are allocated (for example if
ucc_fast_init fails). The current code doesn't check if p_tx_bd_ring[i]
is null, generating a kernel panic when trying to free the associated
socket buffers.
The function can also fail when accessing the uninitialized list_head
structures ugeth->group_hash_q and ugeth->ind_hash_q. In the current
implementation the list heads are initialized only when
maxGroupAddrInHash and maxIndAddrInHash are positive values, although I
think it's better to always initialize them.
Signed-off-by: Ionut Nicu <ionut.nicu@freescale.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions