diff options
author | Jean Delvare <khali@linux-fr.org> | 2005-09-22 22:01:07 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-10-28 14:02:08 -0700 |
commit | c2f559d5df5751780c0bd3ea0bd0aa17d47c0b39 (patch) | |
tree | 96af915d018b5145b6e57bf450f5cd29cebeca79 /Documentation/i2c/busses/i2c-viapro | |
parent | f118301416953d677de738100c33eb8cfb7adecb (diff) |
[PATCH] i2c-viapro: Code cleanups
Cleanups to the i2c-viapro driver:
* Kill unused defines.
* Kill interrupt-related code, as the driver doesn't use interrupts.
* Fix broken comments (some copied from i2c-piix4.)
* Centralize the unsupported command error case in vt596_access.
That way we'll catch all unsupported commands, not only
I2C_SMBUS_PROC_CALL.
* Refactor some code.
* Convert some dev_dbg into dev_err. Errors better be reported even in
non-debug mode.
* Do not verify that the final reset succeeded. It'll be checked at
the beginning of the next transaction anyway.
* Use the driver name to reserve the I/O region.
* Do not print the contents of the SMBREV register, it reads 0 on all
chips I've seen so far.
* Some other minor fixes all over the place.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/i2c/busses/i2c-viapro.c | 122 +++++++++++++---------------------------
1 file changed, 41 insertions(+), 81 deletions(-)
Diffstat (limited to 'Documentation/i2c/busses/i2c-viapro')
0 files changed, 0 insertions, 0 deletions