diff options
author | Geert Uytterhoeven <geert+renesas@linux-m68k.org> | 2014-02-25 11:40:16 +0100 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-02-27 13:50:33 +0900 |
commit | e6456186cae76f80446ba911f77eb2f85d3d927e (patch) | |
tree | 0dc81d3d47f8c7e7611c3fdb66068cd6ee8d6944 /Documentation/spi | |
parent | 925d16a209b40a3e7202a4f867991fb608834d36 (diff) |
spi: spidev: Restore all SPI mode flags on ioctl failure
In commit f477b7fb13df2b843997559ff34e87d054ba6538 ("spi: DUAL and QUAD
support"), spi_device.mode was enlarged from 8 to 16 bits.
However, the spidev code still only saved 8 bits of data. If a spidev
SPI_IOC_WR_MODE or SPI_IOC_WR_LSB_FIRST request failed, only the lower 8
bits of the SPI mode were restored, inadvertently clearing the upper 8
bits, possibly disabling Quad or Dual SPI transfers for the device.
Save up to 32 bits to fix this.
For SPI_IOC_WR_MODE this is probably not so important, as it doesn't allow
setting Quad or Dual mode anyway, but SPI_IOC_WR_LSB_FIRST is used to just
set or clear a single bit.
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'Documentation/spi')
0 files changed, 0 insertions, 0 deletions