diff options
| author | Josef 'Jeff' Sipek <jeffpc@josefsipek.net> | 2008-08-21 19:46:31 +0200 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2008-08-21 19:46:39 +0200 |
| commit | 3e972394f9ee1511e5fdbcf50ac7d79e9cf563bd (patch) | |
| tree | 24aa87f71b07e119a7b308ff4fec2b43bd61c63e /arch/s390 | |
| parent | 0983e56835cbf4796e8f5780c549c32ac1c3afac (diff) | |
[S390] Fix uninitialized spinlock use
Ever since commit 43ca5c3a1cefdaa09231d64485b8f676118bf1e0 ([S390] Convert
monitor calls to function calls.), the kernel refused to IPL with spinlock
debugging enabled.
BUG: spinlock bad magic on CPU#0, swapper/0
lock: 00000000003a4668, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
CPU: 0 Not tainted 2.6.25 #1
Process swapper (pid: 0, task: 000000000034f958, ksp: 0000000000377d60)
0000000000377ab8 0000000000352628 0000000000377d60 0000000000377d60
0000000000016af4 00000000fffff7b5 0000000000377d60 0000000000000000
0000000000000000 0000000000377a18 0000000000000009 0000000000377a18
0000000000377a78 000000000023c920 0000000000016af4 0000000000377a18
0000000000000005 0000000000000000 0000000000377b58 0000000000377ab8
Call Trace:
([<0000000000016a60>] show_trace+0xdc/0x108)
[<0000000000016b4e>] show_stack+0xc2/0xfc
[<0000000000016c9a>] dump_stack+0xb2/0xc0
[<0000000000172dd4>]
Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'arch/s390')
| -rw-r--r-- | arch/s390/kernel/process.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c index 9839767d084..3e2c05cb6a8 100644 --- a/arch/s390/kernel/process.c +++ b/arch/s390/kernel/process.c @@ -75,7 +75,9 @@ unsigned long thread_saved_pc(struct task_struct *tsk) return sf->gprs[8]; } -DEFINE_PER_CPU(struct s390_idle_data, s390_idle); +DEFINE_PER_CPU(struct s390_idle_data, s390_idle) = { + .lock = __SPIN_LOCK_UNLOCKED(s390_idle.lock) +}; static int s390_idle_enter(void) { |