diff options
| author | Matt Fleming <matt@console-pimps.org> | 2009-08-16 21:54:48 +0100 |
|---|---|---|
| committer | Matt Fleming <matt@console-pimps.org> | 2009-08-21 13:02:44 +0100 |
| commit | b344e24a8e8ceda83d1285d22e3e5baf4f5e42d3 (patch) | |
| tree | 4b9500264a797736b48b59c3f0977277ace53386 /arch/sh/kernel/debugtraps.S | |
| parent | 97efbbd5886e27b61c19c77d41f6491f5d96fbd0 (diff) | |
sh: unwinder: Introduce UNWINDER_BUG() and UNWINDER_BUG_ON()
We can't assume that if we execute the unwinder code and the unwinder
was already running that it has faulted. Clearly two kernel threads can
invoke the unwinder at the same time and may be running simultaneously.
The previous approach used BUG() and BUG_ON() in the unwinder code to
detect whether the unwinder was incapable of unwinding the stack, and
that the next available unwinder should be used instead. A better
approach is to explicitly invoke a trap handler to switch unwinders when
the current unwinder cannot continue.
Signed-off-by: Matt Fleming <matt@console-pimps.org>
Diffstat (limited to 'arch/sh/kernel/debugtraps.S')
| -rw-r--r-- | arch/sh/kernel/debugtraps.S | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/arch/sh/kernel/debugtraps.S b/arch/sh/kernel/debugtraps.S index 591741383ee..cb00e4a82d4 100644 --- a/arch/sh/kernel/debugtraps.S +++ b/arch/sh/kernel/debugtraps.S @@ -21,6 +21,10 @@ #define sh_bios_handler debug_trap_handler #endif +#if !defined(CONFIG_DWARF_UNWINDER) +#define unwinder_trap_handler debug_trap_handler +#endif + .data ENTRY(debug_trap_table) @@ -35,7 +39,7 @@ ENTRY(debug_trap_table) .long debug_trap_handler /* 0x38 */ .long debug_trap_handler /* 0x39 */ .long debug_trap_handler /* 0x3a */ - .long debug_trap_handler /* 0x3b */ + .long unwinder_trap_handler /* 0x3b */ .long breakpoint_trap_handler /* 0x3c */ .long singlestep_trap_handler /* 0x3d */ .long bug_trap_handler /* 0x3e */ |