diff options
| author | Stephan Mueller <smueller@chronox.de> | 2014-06-23 09:11:29 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-06-26 14:46:31 +0800 |
| commit | c0eedf803467620fd3bdafccdd761990f6bd42e1 (patch) | |
| tree | 614b96364e374909364275a04b7fbb4a57e3ed1f /crypto | |
| parent | de18cd4b71acecbd1278a7bb79340cbf885212aa (diff) | |
crypto: drbg - simplify ordering of linked list in drbg_ctr_df
As reported by a static code analyzer, the code for the ordering of
the linked list can be simplified.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/drbg.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/crypto/drbg.c b/crypto/drbg.c index faaa2cefeee..99fa8f89fb3 100644 --- a/crypto/drbg.c +++ b/crypto/drbg.c @@ -516,13 +516,13 @@ static int drbg_ctr_df(struct drbg_state *drbg, S2.next = addtl; /* - * splice in addtl between S2 and S4 -- we place S4 at the end of the - * input data chain + * Splice in addtl between S2 and S4 -- we place S4 at the end + * of the input data chain. As this code is only triggered when + * addtl is not NULL, no NULL checks are necessary. */ tempstr = addtl; - for (; NULL != tempstr; tempstr = tempstr->next) - if (NULL == tempstr->next) - break; + while (tempstr->next) + tempstr = tempstr->next; tempstr->next = &S4; /* 10.4.2 step 9 */ |