diff options
| author | Akinobu Mita <akinobu.mita@gmail.com> | 2006-12-19 12:56:09 -0800 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2006-12-20 00:30:48 -0500 |
| commit | f10bb2544bab75b3e8df15a7b51a833c78cbd77f (patch) | |
| tree | 6d099f8c14ccdaca92b2100b8548afe536e56a14 /drivers/acpi | |
| parent | 9185cfa92507d07ac787bc73d06c42222eec7239 (diff) | |
ACPI: fix single linked list manipulation
Fix single linked list manipulation for sub_driver. If the remving entry
is not on the head of the sub_driver list, it goes into infinate loop.
Though that infinite loop doesn't happen. Because the only user of
acpi_pci_register_dirver() is acpiphp.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi')
| -rw-r--r-- | drivers/acpi/pci_root.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c index 0984a1ee24e..c92c144d6c5 100644 --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c @@ -98,11 +98,12 @@ void acpi_pci_unregister_driver(struct acpi_pci_driver *driver) struct acpi_pci_driver **pptr = &sub_driver; while (*pptr) { - if (*pptr != driver) - continue; - *pptr = (*pptr)->next; - break; + if (*pptr == driver) + break; + pptr = &(*pptr)->next; } + BUG_ON(!*pptr); + *pptr = (*pptr)->next; if (!driver->remove) return; |