summaryrefslogtreecommitdiffstats
path: root/drivers/base
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2012-04-06 15:17:32 -0600
committerMark Brown <broonie@opensource.wolfsonmicro.com>2012-04-07 09:25:34 +0100
commit40606dba450830e50420599c52a86cf6ce5c6a14 (patch)
tree05ba5a5027b2e583e8c66b96516ae8d0c7c09944 /drivers/base
parent45f5ff8107a845854b1d1812ab1d9c5541f08b4d (diff)
regmap: mmio: convert some error returns to BUG()
Some of the error conditions detected by regmap_mmio_*() are pure internal errors, rather than user-/client-triggerable conditions. Convert these to BUG(). Signed-off-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/regmap/regmap-mmio.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/base/regmap/regmap-mmio.c b/drivers/base/regmap/regmap-mmio.c
index 1a7b5ee11ab..ffa0e850839 100644
--- a/drivers/base/regmap/regmap-mmio.c
+++ b/drivers/base/regmap/regmap-mmio.c
@@ -35,8 +35,8 @@ static int regmap_mmio_gather_write(void *context,
struct regmap_mmio_context *ctx = context;
u32 offset;
- if (reg_size != 4)
- return -EIO;
+ BUG_ON(reg_size != 4);
+
if (val_size % ctx->val_bytes)
return -EIO;
@@ -60,7 +60,7 @@ static int regmap_mmio_gather_write(void *context,
#endif
default:
/* Should be caught by regmap_mmio_check_config */
- return -EIO;
+ BUG();
}
val_size -= ctx->val_bytes;
val += ctx->val_bytes;
@@ -72,8 +72,8 @@ static int regmap_mmio_gather_write(void *context,
static int regmap_mmio_write(void *context, const void *data, size_t count)
{
- if (count < 4)
- return -EIO;
+ BUG_ON(count < 4);
+
return regmap_mmio_gather_write(context, data, 4, data + 4, count - 4);
}
@@ -84,8 +84,8 @@ static int regmap_mmio_read(void *context,
struct regmap_mmio_context *ctx = context;
u32 offset;
- if (reg_size != 4)
- return -EIO;
+ BUG_ON(reg_size != 4);
+
if (val_size % ctx->val_bytes)
return -EIO;
@@ -109,7 +109,7 @@ static int regmap_mmio_read(void *context,
#endif
default:
/* Should be caught by regmap_mmio_check_config */
- return -EIO;
+ BUG();
}
val_size -= ctx->val_bytes;
val += ctx->val_bytes;