diff options
| author | Inki Dae <inki.dae@samsung.com> | 2011-12-16 21:49:03 +0900 |
|---|---|---|
| committer | Inki Dae <inki.dae@samsung.com> | 2011-12-29 11:21:42 +0900 |
| commit | c32b06ef7dd63a5e0b14a02c96ef308796c157cc (patch) | |
| tree | 4a2cecf7e9f97cc42879cd7afd8567df4582f66a /drivers/gpu/drm/exynos | |
| parent | 52c68814cd7f3592292a02b890b5b8625e9069a7 (diff) | |
drm/exynos: added mutex lock and code clean.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Diffstat (limited to 'drivers/gpu/drm/exynos')
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_fimd.c | 37 |
1 files changed, 25 insertions, 12 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 777b93c0718..ca83139cd30 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -87,6 +87,7 @@ struct fimd_context { u32 vidcon0; u32 vidcon1; bool suspended; + struct mutex lock; struct fb_videomode *timing; }; @@ -137,11 +138,22 @@ static struct exynos_drm_display_ops fimd_display_ops = { static void fimd_dpms(struct device *subdrv_dev, int mode) { + struct fimd_context *ctx = get_fimd_context(subdrv_dev); + DRM_DEBUG_KMS("%s, %d\n", __FILE__, mode); + mutex_lock(&ctx->lock); + switch (mode) { case DRM_MODE_DPMS_ON: - pm_runtime_get_sync(subdrv_dev); + /* + * enable fimd hardware only if suspended status. + * + * P.S. fimd_dpms function would be called at booting time so + * clk_enable could be called double time. + */ + if (ctx->suspended) + pm_runtime_get_sync(subdrv_dev); break; case DRM_MODE_DPMS_STANDBY: case DRM_MODE_DPMS_SUSPEND: @@ -152,6 +164,8 @@ static void fimd_dpms(struct device *subdrv_dev, int mode) DRM_DEBUG_KMS("unspecified mode %d\n", mode); break; } + + mutex_unlock(&ctx->lock); } static void fimd_apply(struct device *subdrv_dev) @@ -803,13 +817,6 @@ static int __devinit fimd_probe(struct platform_device *pdev) goto err_req_irq; } - pm_runtime_set_active(dev); - pm_runtime_enable(dev); - pm_runtime_get_sync(dev); - - for (win = 0; win < WINDOWS_NR; win++) - fimd_clear_win(ctx, win); - ctx->clkdiv = fimd_calc_clkdiv(ctx, timing); ctx->vidcon0 = pdata->vidcon0; ctx->vidcon1 = pdata->vidcon1; @@ -831,7 +838,17 @@ static int __devinit fimd_probe(struct platform_device *pdev) subdrv->manager.display_ops = &fimd_display_ops; subdrv->manager.dev = dev; + mutex_init(&ctx->lock); + platform_set_drvdata(pdev, ctx); + + pm_runtime_set_active(dev); + pm_runtime_enable(dev); + pm_runtime_get_sync(dev); + + for (win = 0; win < WINDOWS_NR; win++) + fimd_clear_win(ctx, win); + exynos_drm_subdrv_register(subdrv); return 0; @@ -894,7 +911,6 @@ out: #ifdef CONFIG_PM_SLEEP static int fimd_suspend(struct device *dev) { - struct fimd_context *ctx = get_fimd_context(dev); int ret; if (pm_runtime_suspended(dev)) @@ -904,13 +920,11 @@ static int fimd_suspend(struct device *dev) if (ret < 0) return ret; - ctx->suspended = true; return 0; } static int fimd_resume(struct device *dev) { - struct fimd_context *ctx = get_fimd_context(dev); int ret; ret = pm_runtime_resume(dev); @@ -931,7 +945,6 @@ static int fimd_resume(struct device *dev) pm_runtime_enable(dev); - ctx->suspended = false; return 0; } #endif |