diff options
| author | Karsten Keil <keil@b1-systems.de> | 2009-07-27 08:20:55 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-07-27 08:20:55 -0700 |
| commit | 663a31ce5bbef2d14fa325023e48bf02b4249f27 (patch) | |
| tree | b1b0d69da31cad32b886f4db5ddd0a746026b2a9 /drivers/isdn/hardware/mISDN/iohelper.h | |
| parent | 70034918930d2e5b68c09bced637228c50d9561a (diff) | |
mISDN: Fix wrong struct name in macro and clarifications
Based on comments from Joe Perches <joe@perches.com>. Thanks.
Fix IOFUNC_MEMIO macro. WriteFiFo##name##_MIO use the wrong struct name,
this was missed because the macro was only called with this name.
Clarify with _func that the defined types are functions.
Add names to the parameters for better understanding the purpose.
Signed-off-by: Karsten Keil <keil@b1-systems.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn/hardware/mISDN/iohelper.h')
| -rw-r--r-- | drivers/isdn/hardware/mISDN/iohelper.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/isdn/hardware/mISDN/iohelper.h b/drivers/isdn/hardware/mISDN/iohelper.h index c16a217301e..b438981107a 100644 --- a/drivers/isdn/hardware/mISDN/iohelper.h +++ b/drivers/isdn/hardware/mISDN/iohelper.h @@ -26,9 +26,9 @@ #ifndef _IOHELPER_H #define _IOHELPER_H -typedef u8 (read_reg_t)(void *, u8); -typedef void (write_reg_t)(void *, u8, u8); -typedef void (fifo_func_t)(void *, u8, u8 *, int); +typedef u8 (read_reg_func)(void *hwp, u8 offset); +typedef void (write_reg_func)(void *hwp, u8 offset, u8 value); +typedef void (fifo_func)(void *hwp, u8 offset, u8 *datap, int size); struct _ioport { u32 port; @@ -90,7 +90,7 @@ struct _ioport { *dp++ = readb(((typ *)hw->adr) + off);\ } \ static void WriteFiFo##name##_MIO(void *p, u8 off, u8 *dp, int size) {\ - struct inf_hw *hw = p;\ + struct hws *hw = p;\ while (size--)\ writeb(*dp++, ((typ *)hw->adr) + off);\ } @@ -106,4 +106,4 @@ struct _ioport { ASSIGN_FUNC(typ, IPAC, target);\ } while (0) -#endif
\ No newline at end of file +#endif |