diff options
author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-06-24 15:57:37 -0300 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2013-07-26 13:28:26 -0300 |
commit | ac22521cb2dc07e0b2193868c647dee5d737f85a (patch) | |
tree | 0bbcb7f5d52aa0f82698278f2987272bc838064b /drivers/media/usb/usbtv | |
parent | 3333447c6946f8a76548d1599686a2bbd11e9264 (diff) |
[media] tlg2300: fix checking firmware in poseidon_probe()
check_firmware() makes sure firmware is in a device.
It returns zero on success and error code otherwise.
Also it sets down_firmware flag to 1 if downloading occurs.
The only caller poseidon_probe() checks down_firmware flag and
returns 0 without any initialization if it is set.
That looks very strange, so the patch removes down_firmware argument
of check_firmware() and returns error code if check_firmware() fails
in poseidon_probe().
Not tested on real hardware.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/usb/usbtv')
0 files changed, 0 insertions, 0 deletions