diff options
author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-04-22 14:42:13 -0300 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-04-24 14:07:44 -0300 |
commit | f13613acfb1a71895ac886dc831d6ae4e20e241a (patch) | |
tree | ead5941f87548b9848837dab2d78d364913037de /drivers/media/video/saa7134/saa7134-empress.c | |
parent | 6a6179b6db401acde5798b4da0fdff32b126ee15 (diff) |
V4L/DVB (7235): tuner-simple: fix a buffer overflow
simple_set_tv() creates a buffer with 4 elements, and calls
simple_std_setup(), passing &buffer[1]. This makes the 5th element of buffer to
be initialized to 0, overriding some area outside the buffer.
Also, simple_std_setup() receives a buffer as parameter, but the buffer is
just overriden after the call, so, it doesn't make much sense to pass it as a
parameter.
This patch removes buffer[] from the function call, creating, instead, a local
var to be used internally.
Thanks to Axel Rometsch <axel.rometsch@freenet.de> for pointing the issue.
Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/saa7134/saa7134-empress.c')
0 files changed, 0 insertions, 0 deletions