summaryrefslogtreecommitdiffstats
path: root/drivers/media/video/saa7164
diff options
context:
space:
mode:
authorJesper Juhl <jj@chaosbits.net>2010-12-18 19:05:02 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2010-12-29 08:17:04 -0200
commitef330dc2e794c932fcbde3f8abd3f12780d78b47 (patch)
treeb5b7e2f70814aa02fce7e2b92c236f06bddb9dea /drivers/media/video/saa7164
parent10304ca65f8871ad9f6725a7480522034184f55f (diff)
[media] saa7164: Remove pointless conditional and save a few bytes in saa7164_downloadfirmware()
Hi, release_firmware() just does nothing if passed a NULL pointer. So there's no reason to test before the call in saa7164-fw.c::saa7164_downloadfirmware(). Removing the pointless conditional also saves a few bytes. before: text data bss dec hex filename 7943 112 2144 10199 27d7 drivers/media/video/saa7164/saa7164-fw.o after: text data bss dec hex filename 7931 112 2136 10179 27c3 drivers/media/video/saa7164/saa7164-fw.o Signed-off-by: Jesper Juhl <jj@chaosbits.net> Cc: Steven Toth <stoth@kernellabs.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/saa7164')
-rw-r--r--drivers/media/video/saa7164/saa7164-fw.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/media/video/saa7164/saa7164-fw.c b/drivers/media/video/saa7164/saa7164-fw.c
index 22b02323dca..ebed6f786a2 100644
--- a/drivers/media/video/saa7164/saa7164-fw.c
+++ b/drivers/media/video/saa7164/saa7164-fw.c
@@ -608,8 +608,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
ret = 0;
out:
- if (fw)
- release_firmware(fw);
-
+ release_firmware(fw);
return ret;
}