diff options
| author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2009-04-17 20:44:29 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-04-20 02:00:38 -0700 |
| commit | 3a6d1bc4163fee27c312184d5f1a9cc1e110d300 (patch) | |
| tree | bc8fc191ed4903b113f4aad58b5504b36df4b5e8 /drivers/net/igb/igb_main.c | |
| parent | 5438646724c34c2180664a57f862a1da8dd21db1 (diff) | |
ixgb: fix link down initial state
As reported by Andrew Lutomirski <amluto@gmail.com>
All the intel wired ethernet drivers were calling netif_carrier_off
and netif_stop_queue (or variants) before calling register_netdevice
This is incorrect behavior as was pointed out by davem, and causes
ifconfig and friends to report a strange state before first link
after the driver was loaded, since without a netif_carrier_off, the stack
assumes carrier_on, but before register_netdev, netlink messages are not
sent out telling link state.
This apparently confused *some* versions of networkmanager.
in addition this driver appeared to need a netif_start_queue at
the end of open.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reported-by: Andrew Lutomirski <amluto@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/igb/igb_main.c')
0 files changed, 0 insertions, 0 deletions