summaryrefslogtreecommitdiffstats
path: root/drivers/net/pcmcia/xirc2ps_cs.c
diff options
context:
space:
mode:
authorDominik Brodowski <linux@dominikbrodowski.net>2009-10-18 18:22:32 +0200
committerDominik Brodowski <linux@dominikbrodowski.net>2009-11-08 18:06:32 +0100
commit7d2e8d00b47b973c92db4df7444d5e6d3bb945f9 (patch)
tree22286fa095d0340245e83ca9c7695f42f65c141a /drivers/net/pcmcia/xirc2ps_cs.c
parent6ae3b84d979308671bf6f6a2123c258a8603d61c (diff)
pcmcia: use pre-determined values
A few PCMCIA network drivers can make use of values provided by the pcmcia core, instead of tedious, independent CIS parsing. xirc32ps_cs.c: manf_id hostap_cs.c: multifunction count b43/pcmcia.c: ConfigBase address and "Present" smc91c92_cs.c: By default, mhz_setup() can use VERS_1 as it is stored in struct pcmcia_device. Only some cards require workarounds, such as reading out VERS_1 twice. CC: David S. Miller <davem@davemloft.net> CC: netdev@vger.kernel.org CC: linux-wireless@vger.kernel.org Acked-by: John W. Linville <linville@tuxdriver.com> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/net/pcmcia/xirc2ps_cs.c')
-rw-r--r--drivers/net/pcmcia/xirc2ps_cs.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c
index cf842310253..5e203230144 100644
--- a/drivers/net/pcmcia/xirc2ps_cs.c
+++ b/drivers/net/pcmcia/xirc2ps_cs.c
@@ -792,13 +792,12 @@ xirc2ps_config(struct pcmcia_device * link)
tuple.TupleOffset = 0;
/* Is this a valid card */
- tuple.DesiredTuple = CISTPL_MANFID;
- if ((err=first_tuple(link, &tuple, &parse))) {
+ if (link->has_manf_id == 0) {
printk(KNOT_XIRC "manfid not found in CIS\n");
goto failure;
}
- switch(parse.manfid.manf) {
+ switch (link->manf_id) {
case MANFID_XIRCOM:
local->manf_str = "Xircom";
break;
@@ -822,6 +821,13 @@ xirc2ps_config(struct pcmcia_device * link)
}
DEBUG(0, "found %s card\n", local->manf_str);
+ /* needed for the additional fields to be parsed by set_card_type() */
+ tuple.DesiredTuple = CISTPL_MANFID;
+ err = first_tuple(link, &tuple, &parse)
+ if (err) {
+ printk(KNOT_XIRC "manfid not found in CIS\n");
+ goto failure;
+ }
if (!set_card_type(link, buf)) {
printk(KNOT_XIRC "this card is not supported\n");
goto failure;