summaryrefslogtreecommitdiffstats
path: root/drivers/net/phy/realtek.c
diff options
context:
space:
mode:
authorBob Copeland <me@bobcopeland.com>2009-12-21 22:26:48 -0500
committerJohn W. Linville <linville@tuxdriver.com>2009-12-28 16:13:47 -0500
commit242ab7ad689accafd5e87ffd22b85cf1bf7fbbef (patch)
treec2d2ae7d19ea71a44020260f183150d64ac8d7f2 /drivers/net/phy/realtek.c
parent2e10d330f8d5f039fa1e00baf59435ab0f11c722 (diff)
ath5k: fix SWI calibration interrupt storm
The calibration period is now invoked by triggering a software interrupt from within the ISR by ath5k_hw_calibration_poll() instead of via a timer. However, the calibration interval isn't initialized before interrupts are enabled, so we can have a situation where an interrupt occurs before the interval is assigned, so the interval is actually negative. As a result, the ISR will arm a software interrupt to schedule the tasklet, and then rearm it when the SWI is processed, and so on, leading to a softlockup at modprobe time. Move the initialization order around so the calibration interval is set before interrupts are active. Another possible fix is to schedule the tasklet directly from the poll routine, but I think there are additional plans for the SWI. Signed-off-by: Bob Copeland <me@bobcopeland.com> Cc: stable@kernel.org Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/phy/realtek.c')
0 files changed, 0 insertions, 0 deletions