diff options
| author | Denys Vlasenko <vda.linux@googlemail.com> | 2008-04-01 02:56:32 +0200 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2008-04-08 15:05:57 -0400 |
| commit | 2aee82de5238625a7664f88d6ebff9de467bb685 (patch) | |
| tree | 9ec1c7dd8e9897db39ea20094d580f7245e6e047 /drivers/net/typhoon.h | |
| parent | 7b463ced635231dd1d4ca6d8b1d93f9353b9dc3a (diff) | |
wavelan_cs: stop inlining largish static functions
Hi John,
Can you please take a look at this patch?
drivers/net/wireless/wavelan_cs.c has unusually large number
of static inline functions - 27.
I looked through them and 20 of them do not seem to warrant inlining.
Some are really big; others call mdelay(1) or busy-wait for a bit
to be set in a hardware register - it's pointless
to optimize such functions for speed.
This patch removes "inline" from these static function
(regardless of number of callsites - gcc nowadays auto-inlines
statics with one callsite).
Size difference for 32bit x86:
text data bss dec hex filename
17020 372 8 17400 43f8 linux-2.6-ALLYES/drivers/net/wireless/wavelan_cs.o
14032 356 8 14396 383c linux-2.6.inline-ALLYES/drivers/net/wireless/wavelan_cs.o
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
--
vda
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/typhoon.h')
0 files changed, 0 insertions, 0 deletions