summaryrefslogtreecommitdiffstats
path: root/drivers/platform
diff options
context:
space:
mode:
authorCorentin Chary <corentincj@iksaif.net>2009-11-28 10:19:55 +0100
committerCorentin Chary <corentincj@iksaif.net>2010-02-28 19:35:09 +0100
commite5b50f6a2b00de266f03c2c7219b798648124ea5 (patch)
tree609c9861cfdebcc9ae129c060ddfb6089e8df9f1 /drivers/platform
parentc45eecf8719e0b2090c8a71bdc31e39d00746c84 (diff)
asus-laptop: no need to check argument of set_brightness()
We already tell the backlight class our maximum brightness value; it will validate the user requested values for us. Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Diffstat (limited to 'drivers/platform')
-rw-r--r--drivers/platform/x86/asus-laptop.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 1d799b3fc4e..013ab86b1c8 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -571,17 +571,11 @@ static int read_brightness(struct backlight_device *bd)
static int set_brightness(struct backlight_device *bd, int value)
{
- int ret = 0;
-
- value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
- /* 0 <= value <= 15 */
-
if (write_acpi_int(brightness_set_handle, NULL, value, NULL)) {
pr_warning("Error changing brightness\n");
- ret = -EIO;
+ return -EIO;
}
-
- return ret;
+ return 0;
}
static int update_bl_status(struct backlight_device *bd)