diff options
| author | Nagendra Singh Tomar <nagendra_tomar@adaptec.com> | 2007-02-02 17:34:56 +0530 |
|---|---|---|
| committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2007-02-02 19:45:41 -0600 |
| commit | 017f2e37ae19ccd28e5edd965741fc374194c5dd (patch) | |
| tree | 10e7f93abebfc1797ccbb342f6ed38f072dd4092 /drivers/scsi/hosts.c | |
| parent | 91614c054c9ffc26b47a5cb3135113aa0f6e6ff0 (diff) | |
[SCSI] sd: udev accessing an uninitialized scsi_disk field results in a crash
sd_probe() calls class_device_add() even before initializing the
sdkp->device variable. class_device_add() eventually results in the user mode
udev program to be called. udev program can read the the allow_restart
attribute of the newly created scsi device. This is resulting in a crash as
the show function for allow_restart (i.e sd_show_allow_restart) returns the
attribute value by reading the sdkp->device->allow_restart variable. As the
sdkp->device is not initialized before calling the user mode hotplug helper,
this results in a crash.
The patch below solves it by calling class_device_add() only after the
necessary fields in the scsi_disk structure are initialized properly.
Signed-off-by: Nagendra Singh Tomar <nagendra_tomar@adaptec.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/hosts.c')
0 files changed, 0 insertions, 0 deletions