diff options
author | Tejun Heo <htejun@gmail.com> | 2006-02-11 19:11:13 +0900 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2006-02-11 17:51:57 -0500 |
commit | a46314744d8fadb91451bf2e5d2fd949c4a752d8 (patch) | |
tree | 46757778593f4d24d4b69a5cefd522d22d60abcf /drivers/scsi/scsicam.c | |
parent | 4bd00f6a201897af4cd50250a761e6bc4b2221ec (diff) |
[PATCH] libata: convert assert(X)'s in libata core layer to WARN_ON(!X)'s
In an effort to kill libata-specific assert() and use generic
WARN_ON(), this patch converts all assert(X)'s in libata core layer to
WARN_ON(!X)'s. Most conversions are straight-forward logical negation
exception for the followings.
* In libata-core.c:ata_fill_sg(),
assert(qc->n_elem > 0) is converted to WARN_ON(qc->n_elem == 0) because
qc->n_elem is unsigned and unsigned <= 0 is weird.
* In libata-scsi.c:ata_gen_ata_desc/fixed_sense(),
assert(NULL != qc->ap->ops->tf_read) is converted to
WARN_ON(qc->ap->ops->tf_read == NULL), as there are no other users of
'constant cond var' style in libata.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/scsi/scsicam.c')
0 files changed, 0 insertions, 0 deletions