diff options
| author | Matthijs Kooijman <matthijs@stdin.nl> | 2013-04-11 17:52:41 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-04-11 12:58:39 -0700 |
| commit | 6706c721b22aadffbffec7550b81efedddd05cfb (patch) | |
| tree | e763faf21c606750ae874fcd45258744f6fd1116 /drivers/staging/dwc2/pci.c | |
| parent | 7c360aa7cd6b469671fc2ea7a889516095cd0efe (diff) | |
staging: dwc2: register common irq handler in dwc2_core_init
Before, this was initialized in pci.c, after the dwc2_hcd_init was
called and the interrupts were enabled. This opened up a small time
window where common interrupts could be triggered, but there was no
handler for them, causing them to keep triggering infinitely and locking
up the machine.
On my RT3052 board this bug could be easily reproduced by hardcoding
the console log level to 8, so that a bunch of debug output from the dwc2
driver was generated inside this time window. This caused the interrupt
lockup to occur almost every time.
By requesting the irq inside dwc2_core_init and by disabling interrupts
before calling dwc2_core_init instead of after, we can be sure the
handler is registered before the interrupts are enabled, which should
close this window.
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/dwc2/pci.c')
| -rw-r--r-- | drivers/staging/dwc2/pci.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c index 80808d82aa7..8d9a9023c29 100644 --- a/drivers/staging/dwc2/pci.c +++ b/drivers/staging/dwc2/pci.c @@ -155,13 +155,6 @@ static int dwc2_driver_probe(struct pci_dev *dev, pci_set_drvdata(dev, hsotg); dev_dbg(&dev->dev, "hsotg=%p\n", hsotg); - dev_dbg(&dev->dev, "registering common handler for irq%d\n", dev->irq); - retval = devm_request_irq(&dev->dev, dev->irq, dwc2_handle_common_intr, - IRQF_SHARED, dev_name(&dev->dev), - hsotg); - if (retval) - dwc2_hcd_remove(hsotg); - return retval; } |