summaryrefslogtreecommitdiffstats
path: root/drivers/tty/mxser.c
diff options
context:
space:
mode:
authorJiri Slaby <jslaby@suse.cz>2012-08-13 10:18:09 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-08-13 16:57:58 -0700
commita342ca1c78627c3a8b2a8c4e6d5f6ab1b88e6169 (patch)
tree7004ec8bafe586bf93c0cf72a8e72f02652f8cb0 /drivers/tty/mxser.c
parent27bf7c43a19c66bdc96ee3ee5a67e3bc2d601736 (diff)
TTY: mxser, fix invalid module_parm permissions
444 means 0674 and we do not definitely want that. Use S_IRUGO which is much more safer. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Reported-by: Rusty Russell <rusty@ozlabs.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/mxser.c')
-rw-r--r--drivers/tty/mxser.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index 8bc265154ad..bb2da4ca825 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -2338,7 +2338,7 @@ static struct tty_port_operations mxser_port_ops = {
*/
static bool allow_overlapping_vector;
-module_param(allow_overlapping_vector, bool, 444);
+module_param(allow_overlapping_vector, bool, S_IRUGO);
MODULE_PARM_DESC(allow_overlapping_vector, "whether we allow ISA cards to be configured such that vector overlabs IO ports (default=no)");
static bool mxser_overlapping_vector(struct mxser_board *brd)