diff options
author | Julia Lawall <julia@diku.dk> | 2010-10-27 15:33:26 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-27 18:03:08 -0700 |
commit | 847fb8aca3b79d03ef6c5f87f0843a30ed9e6627 (patch) | |
tree | b1916b554960b20d4e7e158cfc803f575cc40a1c /drivers/video/controlfb.c | |
parent | f0a2f357d46a51f8066eb47b3dba40f87a680804 (diff) |
drivers/video/matrox/matroxfb_maven.c: fix unsigned return type
The function has an unsigned return type, but returns a negative constant
to indicate an error condition. The result of calling the function is
only tested by comparison to 0, and thus unsigned is not needed and can be
dropped from the return type.
A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@exists@
identifier f;
constant C;
@@
unsigned f(...)
{ <+...
* return -C;
...+> }
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/controlfb.c')
0 files changed, 0 insertions, 0 deletions