summaryrefslogtreecommitdiffstats
path: root/drivers/video/smscufx.c
diff options
context:
space:
mode:
authorTomi Valkeinen <tomi.valkeinen@ti.com>2013-04-18 08:39:47 +0300
committerTomi Valkeinen <tomi.valkeinen@ti.com>2013-04-26 08:28:56 +0300
commit04f8afbec37f63fafce16e454a7848426aa36202 (patch)
tree1c761c03f67ebdc71163aaaf0389a092f29916c6 /drivers/video/smscufx.c
parent11bd5933abe033fb7a3a0d1f1bd2cb4b6df8143f (diff)
fbdev: improve fb_mmap bounds checks
Improve fb_mmap bounds checks in gbefb, smscufx, udlfb and vfb drivers to prevent possible uint overflows. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: Steve Glendinning <steve.glendinning@smsc.com> Cc: Bernie Thompson <bernie@plugable.com>
Diffstat (limited to 'drivers/video/smscufx.c')
-rw-r--r--drivers/video/smscufx.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c
index 97bd6620c36..b2b33fc1ac3 100644
--- a/drivers/video/smscufx.c
+++ b/drivers/video/smscufx.c
@@ -782,7 +782,11 @@ static int ufx_ops_mmap(struct fb_info *info, struct vm_area_struct *vma)
unsigned long offset = vma->vm_pgoff << PAGE_SHIFT;
unsigned long page, pos;
- if (offset + size > info->fix.smem_len)
+ if (vma->vm_pgoff > (~0UL >> PAGE_SHIFT))
+ return -EINVAL;
+ if (size > info->fix.smem_len)
+ return -EINVAL;
+ if (offset > info->fix.smem_len - size)
return -EINVAL;
pos = (unsigned long)info->fix.smem_start + offset;