diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-06-25 10:09:57 +0800 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2013-06-25 12:20:06 +0200 |
| commit | 00cf99ee00c9f1241359c8ee5ca9230318e27a57 (patch) | |
| tree | fdc55d0586d97830851444ceb48e3a9c11fa7d7d /drivers | |
| parent | 99b82abb0a35b07310ea6334257829af168c8e08 (diff) | |
pwm: renesas-tpu: fix return value check in tpu_probe()
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/pwm/pwm-renesas-tpu.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c index 96e0cc488a4..03c1aa3c48a 100644 --- a/drivers/pwm/pwm-renesas-tpu.c +++ b/drivers/pwm/pwm-renesas-tpu.c @@ -410,10 +410,8 @@ static int tpu_probe(struct platform_device *pdev) } tpu->base = devm_ioremap_resource(&pdev->dev, res); - if (tpu->base == NULL) { - dev_err(&pdev->dev, "failed to remap I/O memory\n"); - return -ENXIO; - } + if (IS_ERR(tpu->base)) + return PTR_ERR(tpu->base); tpu->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(tpu->clk)) { |