diff options
author | J. Bruce Fields <bfields@citi.umich.edu> | 2006-04-10 22:55:36 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-11 06:18:52 -0700 |
commit | 6f54e2d0d3a904e55c9c50b78542072f6c42080e (patch) | |
tree | cde5f03d8e80477c7bebcde0e41c48df85dd9846 /fs/nfsd/nfs3acl.c | |
parent | dfee55f06213a23b250ea63ba41caa461cdd5e72 (diff) |
[PATCH] knfsd: svcrpc: WARN() instead of returning an error from svc_take_page
Every caller of svc_take_page ignores its return value and assumes it
succeeded. So just WARN() instead of returning an ignored error. This would
have saved some time debugging a recent nfsd4 problem.
If there are still failure cases here, then the result is probably that we
overwrite an earlier part of the reply while xdr-encoding.
While the corrupted reply is a nasty bug, it would be worse to panic here and
create the possibility of a remote DOS; hence WARN() instead of BUG().
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Cc: Ingo Oeser <ioe-lkml@rameria.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/nfsd/nfs3acl.c')
0 files changed, 0 insertions, 0 deletions