diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2011-03-04 13:14:21 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-03-04 13:14:21 -0500 |
commit | 1858efd471624ecb37e6b5462cab8076f47d1cee (patch) | |
tree | 29d1e5d2aad63b798e880011fc527bb4bab63e40 /fs/proc/proc_sysctl.c | |
parent | b65a0e0c84cf489bfa00d6aa6c48abc5a237100f (diff) |
minimal fix for do_filp_open() race
failure exits on the no-O_CREAT side of do_filp_open() merge with
those of O_CREAT one; unfortunately, if do_path_lookup() returns
-ESTALE, we'll get out_filp:, notice that we are about to return
-ESTALE without having trying to create the sucker with LOOKUP_REVAL
and jump right into the O_CREAT side of code. And proceed to try
and create a file. Usually that'll fail with -ESTALE again, but
we can race and get that attempt of pathname resolution to succeed.
open() without O_CREAT really shouldn't end up creating files, races
or not. The real fix is to rearchitect the whole do_filp_open(),
but for now splitting the failure exits will do.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/proc/proc_sysctl.c')
0 files changed, 0 insertions, 0 deletions