diff options
author | Christoph Hellwig <hch@infradead.org> | 2011-08-27 05:57:44 +0000 |
---|---|---|
committer | Alex Elder <aelder@sgi.com> | 2011-08-31 17:59:39 -0500 |
commit | 866e4ed77448a0c311e1b055eb72ea05423fd799 (patch) | |
tree | 96180dbd62cc578f48404d639df87163a337135f /fs/udf/dir.c | |
parent | 242d621964dd8641df53f7d51d4c6ead655cc5a6 (diff) |
xfs: fix xfs_mark_inode_dirty during umount
During umount we do not add a dirty inode to the lru and wait for it to
become clean first, but force writeback of data and metadata with
I_WILL_FREE set. Currently there is no way for XFS to detect that the
inode has been redirtied for metadata operations, as we skip the
mark_inode_dirty call during teardown. Fix this by setting i_update_core
nanually in that case, so that the inode gets flushed during inode reclaim.
Alternatively we could enable calling mark_inode_dirty for inodes in
I_WILL_FREE state, and let the VFS dirty tracking handle this. I decided
against this as we will get better I/O patterns from reclaim compared to
the synchronous writeout in write_inode_now, and always marking the inode
dirty in some way from xfs_mark_inode_dirty is a better safetly net in
either case.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
(cherry picked from commit da6742a5a4cc844a9982fdd936ddb537c0747856)
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/udf/dir.c')
0 files changed, 0 insertions, 0 deletions