diff options
| author | Christoph Hellwig <hch@infradead.org> | 2009-10-12 23:42:10 +0000 |
|---|---|---|
| committer | Alex Elder <aelder@sgi.com> | 2009-10-13 13:16:36 -0500 |
| commit | 05277c75f6dea8ecf59138cd1b6781fb54ae08bd (patch) | |
| tree | e61d1206c3201b306f4fadeb1a4fb2cdd55fa887 /fs/xfs/quota/xfs_qm_syscalls.c | |
| parent | d0800703febc04827b8fa91921aa4e254d01e8d1 (diff) | |
xfs: fix double IRELE in xfs_dqrele_inode
xfs_dqrele_inode calls xfs_iput to release the ilock and a reference
and then also calls IRELE which does a second decrement of the reference
count. This leads to a premature freeing of inodes when quotas were turned
off while the filesystem was mounted.
Thanks to Utako Kusaka for reporting the bug and provinding a good testcase.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Utako Kusaka <u-kusaka@wm.jp.nec.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/quota/xfs_qm_syscalls.c')
| -rw-r--r-- | fs/xfs/quota/xfs_qm_syscalls.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/xfs/quota/xfs_qm_syscalls.c b/fs/xfs/quota/xfs_qm_syscalls.c index 4e4276b956e..5d1a3b98a6e 100644 --- a/fs/xfs/quota/xfs_qm_syscalls.c +++ b/fs/xfs/quota/xfs_qm_syscalls.c @@ -876,7 +876,6 @@ xfs_dqrele_inode( ip->i_gdquot = NULL; } xfs_iput(ip, XFS_ILOCK_EXCL); - IRELE(ip); return 0; } |