diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2012-08-01 13:07:04 +0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-08-01 16:53:16 +0400 |
| commit | dbc6e0222d79e78925fe20733844a796a4b72cf9 (patch) | |
| tree | 49eabccaa420103bd5ecddc2b77bc916440db812 /fs/xfs/xfs_attr.c | |
| parent | 06fd516c1a504828780fcd81dfe21f94dec4c868 (diff) | |
delousing target_core_file a bit
* set_fs(KERNEL_DS) + getname() is probably the weirdest implementation
of strdup() I've seen. Especially since they don't to copy it at all...
* filp_open() never returns NULL; it's ERR_PTR(-E...) on failure.
* file->f_dentry is never going to be NULL, TYVM.
* match_strdup() + snprintf() + kfree() is a bloody weird way to spell
match_strlcpy().
Pox on cargo-cult programmers...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/xfs/xfs_attr.c')
0 files changed, 0 insertions, 0 deletions