diff options
author | Hans de Goede <hdegoede@redhat.com> | 2009-01-07 16:37:28 +0100 |
---|---|---|
committer | Jean Delvare <khali@linux-fr.org> | 2009-01-07 16:37:28 +0100 |
commit | ce0bfa5ee25ddbe4072b16054e809f552bf72320 (patch) | |
tree | 35418be8a28fcaf8cc65cf3d829d13f1f0ef4f3d /fs | |
parent | 7567a0435520fe61420ff2cdc4cec1b5399a5134 (diff) |
hwmon: (f71882fg) Fix various sysfs callback function issues
While working on adding F8000 support I noticed that various of the
store sysfs functions (and a few of the show also) had issues.
This patch fixes the following issues in these functions:
* store: storing the result of strto[u]l in an int, resulting in a possible
overflow before boundary checking
* store: use of f71882fg_update_device(), we don't want to read the whole
device in store functions, just the registers we need
* store: use of cached register values instead of reading the needed regs
in the store function, including cases where f71882fg_update_device() was
not used, this could cause real isues
* show: shown value is a calculation of 2 or more cached register reads,
without locking the data struct.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions