summaryrefslogtreecommitdiffstats
path: root/include/drm
diff options
context:
space:
mode:
authorXi Wang <xi.wang@gmail.com>2011-11-23 01:12:01 -0500
committerDave Airlie <airlied@redhat.com>2011-11-23 08:59:28 +0000
commita5cd335165e31db9dbab636fd29895d41da55dd2 (patch)
tree4d01d5801047b466c44c40231773e66a9dfb704d /include/drm
parentc916874d60d9daf2e2d5f4f622b185ef57deb6a4 (diff)
drm: integer overflow in drm_mode_dirtyfb_ioctl()
There is a potential integer overflow in drm_mode_dirtyfb_ioctl() if userspace passes in a large num_clips. The call to kmalloc would allocate a small buffer, and the call to fb->funcs->dirty may result in a memory corruption. Reported-by: Haogang Chen <haogangchen@gmail.com> Signed-off-by: Xi Wang <xi.wang@gmail.com> Cc: stable@kernel.org Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'include/drm')
-rw-r--r--include/drm/drm_mode.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index d30bedfeb7e..ddd46db65b5 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -235,6 +235,8 @@ struct drm_mode_fb_cmd {
#define DRM_MODE_FB_DIRTY_ANNOTATE_FILL 0x02
#define DRM_MODE_FB_DIRTY_FLAGS 0x03
+#define DRM_MODE_FB_DIRTY_MAX_CLIPS 256
+
/*
* Mark a region of a framebuffer as dirty.
*