diff options
author | Jeff Garzik <jeff@garzik.org> | 2009-12-07 11:41:25 -0500 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2009-12-07 11:41:25 -0500 |
commit | 1b52f2a41c41052d2a7c78af0bd9b8b11d70f49a (patch) | |
tree | f71bd703c40d3b5dec2e9db074e2ea43c0d8f4a5 /include/linux/lp.h | |
parent | d0634c4aea0b80447cbdc4c0db285004b860c455 (diff) |
Revert "pata_sis: Implement MWDMA for the UDMA 133 capable chips"
This reverts commit f20941f334d8fdb6b598658979709b4e94cd034b.
Sergei Shtylyov notes "You call min() on uncomparables [in
mwdma_clip_to_pio()], i.e. mwdma_to_pio[] contains XFER_PIO_* and
adev->pio_mode - XFER_PIO_0 yields you a mode number. Thus the second
argument will always "win" as a minimal one"
Bartlomiej Zolnierkiewicz adds "There are more issues with the patch related
to mwdma_clip_to_pio(). The function can return values between 0 and
4 which obviously won't work well for the new code below for values
>2 (i.e. resulting in out-of-bounds array access for the common-case
of dev->pio_mode == XFER_PIO_4)."
Bartlomiej Zolnierkiewicz also notes the patch is incomplete, failing to
update MWDMA mode masks.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'include/linux/lp.h')
0 files changed, 0 insertions, 0 deletions