diff options
author | Jiri Slaby <jslaby@suse.cz> | 2011-08-25 15:12:04 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-08-25 09:00:39 -0700 |
commit | 426929f8d3514d7f727b8c464d1eeeaf74b21519 (patch) | |
tree | 05f84b3f6e0182dfee2f0cb720f2acc36a4134ba /include/linux/tty.h | |
parent | dfc97fcebd6a9a85335adcfc0e4d0a204bbaea35 (diff) |
TTY: serial, use ASYNCB_CLOSING in uart_close
We need to move port->mutex locking after wait_until_sent in
uart_close (for rationale see next patches). But if we did it now, we
would introduce a race between close and open. This is exactly why
port->mutex is locked at the top of uart_close.
To avoid the race, we add ASYNCB_CLOSING to uart_close. Like every
other sane TTY driver. Thanks to tty_port_block_til_ready used in
uart_open we will have this for free. Then we can move the port->mutex
lock.
Also note that this will make the conversion to tty_port helpers
easier. They are currently handling ASYNC_CLOSING flag correctly.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include/linux/tty.h')
0 files changed, 0 insertions, 0 deletions