summaryrefslogtreecommitdiffstats
path: root/lib/crc8.c
diff options
context:
space:
mode:
authorBen Widawsky <benjamin.widawsky@intel.com>2014-07-01 11:17:47 -0700
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-07-23 07:05:39 +0200
commit2f295791312937d077cecec4cd8f453ce2ce93df (patch)
tree7785bb482d006b51f9ad0c0a176c0a172d9c9658 /lib/crc8.c
parent36362ad3b64acd5e4d438db480bdb80a4ff75eb2 (diff)
drm/i915: Reorder ctx unref on ppgtt cleanup
The comment [which was mine] is wrong. The context object can never be bound in a PPGTT because it is only capable of living in the Global GTT. So, remove the comment, and reorder the unref. What's nice about the latter is it keeps the context object alive past the PPGTT. This makes the destroy ordering symmetric with the creation ordering. Create: 1. Create context 2. Create PPGTT Destroy: 1. Destroy PPGTT 2. Destroy context As far as I know, this does not fix a bug. The code previously kept the context data structure, only the object was gone. As the code was, nothing tried to use the object after this point. NOTE: If in the future we have cases where the PPGTT can/should outlive the context (which doesn't occur today, but the code permits it), this ordering does not matter. Even if this occurs, as it stands now, we do not expect that to be the normal case, and having this order makes debugging a bit easier if we're tracking object lifetimes for the context vs ppgtt Signed-off-by: Ben Widawsky <ben@bwidawsk.net> [danvet: Resolve conflict with Oscar's execlist prep patches.] Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'lib/crc8.c')
0 files changed, 0 insertions, 0 deletions