diff options
author | Christoph Paasch <christoph.paasch@uclouvain.be> | 2014-01-16 20:01:21 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-01-17 18:05:34 -0800 |
commit | 77f99ad16a07aa062c2d30fae57b1fee456f6ef6 (patch) | |
tree | d95bb59a1fdcab37cd1eef6d909a4e75fc75d4c5 /net/ipv6 | |
parent | c196403b79aa241c3fefb3ee5bb328aa7c5cc860 (diff) |
tcp: metrics: Avoid duplicate entries with the same destination-IP
Because the tcp-metrics is an RCU-list, it may be that two
soft-interrupts are inside __tcp_get_metrics() for the same
destination-IP at the same time. If this destination-IP is not yet part of
the tcp-metrics, both soft-interrupts will end up in tcpm_new and create
a new entry for this IP.
So, we will have two tcp-metrics with the same destination-IP in the list.
This patch checks twice __tcp_get_metrics(). First without holding the
lock, then while holding the lock. The second one is there to confirm
that the entry has not been added by another soft-irq while waiting for
the spin-lock.
Fixes: 51c5d0c4b169b (tcp: Maintain dynamic metrics in local cache.)
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
0 files changed, 0 insertions, 0 deletions