diff options
| author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2009-02-13 08:33:42 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-16 00:03:10 -0800 |
| commit | 4458f04c02a46c679a90ef71f866a415c192deb4 (patch) | |
| tree | b08aa476ab4c525ab3cb33cea6114cb262cb2941 /net/sctp/input.c | |
| parent | 06e868066e3b5828383eb40ff4d1c0029100b0b5 (diff) | |
sctp: Clean up sctp checksumming code
The sctp crc32c checksum is always generated in little endian.
So, we clean up the code to treat it as little endian and remove
all the __force casts.
Suggested by Herbert Xu.
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/input.c')
| -rw-r--r-- | net/sctp/input.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/net/sctp/input.c b/net/sctp/input.c index 693fd080481..d2e98803ffe 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -83,14 +83,15 @@ static inline int sctp_rcv_checksum(struct sk_buff *skb) { struct sk_buff *list = skb_shinfo(skb)->frag_list; struct sctphdr *sh = sctp_hdr(skb); - __be32 cmp = sh->checksum; - __be32 val = sctp_start_cksum((__u8 *)sh, skb_headlen(skb)); + __le32 cmp = sh->checksum; + __le32 val; + __u32 tmp = sctp_start_cksum((__u8 *)sh, skb_headlen(skb)); for (; list; list = list->next) - val = sctp_update_cksum((__u8 *)list->data, skb_headlen(list), - val); + tmp = sctp_update_cksum((__u8 *)list->data, skb_headlen(list), + tmp); - val = sctp_end_cksum(val); + val = sctp_end_cksum(tmp); if (val != cmp) { /* CRC failure, dump it. */ |