diff options
| author | Eric Dumazet <edumazet@google.com> | 2013-11-23 12:59:20 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-11-23 14:46:25 -0800 |
| commit | 4d0820cf6a55d72350cb2d24a4504f62fbde95d9 (patch) | |
| tree | 3b390515d5e298866f9f00b611adc821a4137676 /net/sunrpc/timer.c | |
| parent | 1fa4c710b6fe7b0aac9907240291b6fe6aafc3b8 (diff) | |
sch_tbf: handle too small burst
If a too small burst is inadvertently set on TBF, we might trigger
a bug in tbf_segment(), as 'skb' instead of 'segs' was used in a
qdisc_reshape_fail() call.
tc qdisc add dev eth0 root handle 1: tbf latency 50ms burst 1KB rate
50mbit
Fix the bug, and add a warning, as such configuration is not
going to work anyway for non GSO packets.
(For some reason, one has to use a burst >= 1520 to get a working
configuration, even with old kernels. This is a probable iproute2/tc
bug)
Based on a report and initial patch from Yang Yingliang
Fixes: e43ac79a4bc6 ("sch_tbf: segment too big GSO packets")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sunrpc/timer.c')
0 files changed, 0 insertions, 0 deletions