diff options
| author | Takashi Iwai <tiwai@suse.de> | 2006-10-18 19:09:46 +0200 |
|---|---|---|
| committer | Jaroslav Kysela <perex@suse.cz> | 2006-10-22 10:51:13 +0200 |
| commit | dbedca39fe30db87b6401e4396f959c63d90082e (patch) | |
| tree | 9fc6303fd7ac83d62360896534b4964bc4245c5e /sound/core/info.c | |
| parent | 5b15c95f889c7bc43cb759c27211c597c0ad9f05 (diff) | |
[ALSA] Fix re-use of va_list
The va_list is designed to be used only once. The current code
may pass va_list arguments multiple times and may cause Oops.
Copy/release the arguments temporarily to avoid this problem.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
Diffstat (limited to 'sound/core/info.c')
| -rw-r--r-- | sound/core/info.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sound/core/info.c b/sound/core/info.c index e43662b33f1..0b4aab3225e 100644 --- a/sound/core/info.c +++ b/sound/core/info.c @@ -120,7 +120,10 @@ int snd_iprintf(struct snd_info_buffer *buffer, char *fmt,...) len = buffer->len - buffer->size; va_start(args, fmt); for (;;) { - res = vsnprintf(buffer->buffer + buffer->curr, len, fmt, args); + va_list ap; + va_copy(ap, args); + res = vsnprintf(buffer->buffer + buffer->curr, len, fmt, ap); + va_end(ap); if (res < len) break; err = resize_info_buffer(buffer, buffer->len + PAGE_SIZE); |